Skip to content

fix: exec log now properly renders return values#1546

Merged
itayd merged 1 commit intomainfrom
itay/fix-log
Feb 12, 2026
Merged

fix: exec log now properly renders return values#1546
itayd merged 1 commit intomainfrom
itay/fix-log

Conversation

@itayd
Copy link
Member

@itayd itayd commented Feb 11, 2026

Description

Fix: Session execution log return values not rendering

Problem

Return values in the Session Execution Log were not displaying correctly - they appeared as non-expandable items showing character counts (e.g., "180 items") instead
of the actual JSON data.

Root Cause

  1. Parsed return values weren't wrapped in the correct DeepProtoValueResult structure, causing activity.returnValue.value to be undefined
  2. JSON return values could be double-encoded (JSON string containing JSON string), causing JsonViewer to treat them as character arrays instead of objects

Changes

src/models/activity.model.ts:85-103

  • Wrapped parsed return values in proper { type: "object", value: parsedValue } structure
  • Added double-parse logic to handle nested JSON strings
  • Added fallback to wrap plain strings in objects for proper display

src/components/organisms/deployments/sessions/tabs/activities/singleActivityInfo.tsx:68-74

  • Replaced ValueRenderer with JsonViewer for consistency with Arguments/KW Arguments sections
  • Ensured return values are expandable and display correctly

Result

Return values now display and expand correctly in the Session Execution Log, matching the behavior of arguments and kwargs.

What type of PR is this? (check all applicable)

  • 💡 (feat) - A new feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

@itayd itayd requested review from RonenMars and haimzlato February 11, 2026 03:16
@itayd itayd merged commit 490ef9e into main Feb 12, 2026
16 of 20 checks passed
@itayd itayd deleted the itay/fix-log branch February 12, 2026 02:42
@github-actions
Copy link

🎉 This release is now available on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants